Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#51015] Mobile, the participant section should move to details section #14232

Merged
merged 6 commits into from
Nov 28, 2023
Merged

[#51015] Mobile, the participant section should move to details section #14232

merged 6 commits into from
Nov 28, 2023

Conversation

dombesz
Copy link
Contributor

@dombesz dombesz commented Nov 23, 2023 •
edited
Loading

https://community.openproject.org/work_packages/51015

Demo

mobile.meeting.participants.mov

@dombesz dombesz force-pushed the feature/51015-mobile,-the-participant-section-should-move-to-details-section branch from 69d667c to 11603cd Compare November 24, 2023 11:07
@dombesz dombesz marked this pull request as ready for review November 24, 2023 16:12
@oliverguenther oliverguenther self-requested a review November 27, 2023 15:11
oliverguenther
oliverguenther approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@oliverguenther oliverguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a change to use the AsyncDialogComponent so we can lazy load the dialog content. Could you take another look?

@oliverguenther oliverguenther force-pushed the feature/51015-mobile,-the-participant-section-should-move-to-details-section branch from 415b2bc to 0b36a15 Compare November 28, 2023 13:45
@oliverguenther oliverguenther merged commit 2840cf0 into dev Nov 28, 2023
8 of 9 checks passed
@oliverguenther oliverguenther deleted the feature/51015-mobile,-the-participant-section-should-move-to-details-section branch November 28, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverguenther oliverguenther oliverguenther approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dombesz @oliverguenther